Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exceptions system #1014

Open
Spikhalskiy opened this issue Oct 21, 2015 · 0 comments
Open

Improve exceptions system #1014

Spikhalskiy opened this issue Oct 21, 2015 · 0 comments

Comments

@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented Oct 21, 2015

A current set of possible exceptions which you can get in AsyncCompletionHandler#onThrowable is unclear. It's not explained or enumerated in javadocs. Would be great to:

  1. Improve exceptions hierarchy. For example, it's very uncomfortable to get java.io.IOException: Too many connections per host. Theoretically, I can recover from this situation and I want to put this recovery block to catch(TooManyConnectionsPerHostExceptions){} block for example, but I couldn't because we use general-purpose exceptions.

  2. Add javadocs to the onThrowable method with list of possible custom exceptions and reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Triage
  
Triage
Development

No branches or pull requests

2 participants