Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is DefaultAsyncHttpClient ThreadSafe? #1246

Closed
doom369 opened this issue Sep 12, 2016 · 5 comments
Closed

Is DefaultAsyncHttpClient ThreadSafe? #1246

doom369 opened this issue Sep 12, 2016 · 5 comments

Comments

@doom369
Copy link
Contributor

doom369 commented Sep 12, 2016

From code look like not. Am I right?
@doom369 doom369 changed the title Is DefaultAsyncHttpClient is ThreadSafe? Is DefaultAsyncHttpClient ThreadSafe? Sep 12, 2016
@slandelle
Copy link
Contributor

? Why?

@doom369
Copy link
Contributor Author

doom369 commented Sep 12, 2016

My fail, didn't look carefully. I made review again, seems fine. What about adding threadSafe annotation or updating docs as I didn't find any explicit explanation?

@slandelle
Copy link
Contributor

slandelle commented Sep 12, 2016 •
edited

Are you talking about:

See my point: dealing with this is a mess, and I'm not convinced with the added value. What I not is that it will just add a messy dependency.

@doom369
Copy link
Contributor Author

doom369 commented Sep 12, 2016

See my point: dealing with this is a mess

Agree. What about documentation? At least comments?

@slandelle
Copy link
Contributor

The whole AsyncHttpClient javadoc would need a serious update :(
Contribs welcome :)

doom369 added a commit to doom369/async-http-client that referenced this issue Sep 12, 2016
@doom369
AsyncHttpClient#1246 added "ThreadSafe" in comments section for Defau…
d72b89e 
…ltAsyncHttpClient
@doom369 doom369 closed this as completed Sep 12, 2016
slandelle added a commit that referenced this issue Sep 12, 2016
@slandelle
Merge pull request #1249 from doom369/master
0cc215e 
#1246 added "ThreadSafe" in comments section for DefaultAsyncHttpClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slandelle @doom369