Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing middleware design broken #101

Closed
rogeralsing opened this issue Mar 27, 2017 · 6 comments
Closed

Outgoing middleware design broken #101

rogeralsing opened this issue Mar 27, 2017 · 6 comments

Comments

@rogeralsing
Copy link
Contributor

Currently the outgoing middleware has all the parts it needs internally.
but, the Process.SendUserMessage has the signature: (PID pid, object message, PID sender)
which does not allow us for sending outgoing headers.
And if we try to send a MessageEnvelope, things get double wrapped if there is a sender as the LocalProcess checks for sender and wraps the current message in another MessageEnvelope.

TLDR;

We should change the signature of SendUserMessage to just (PID pid, object message) and do the envelope wrapping already in Request

@cpx86
Copy link
Contributor

cpx86 commented Mar 27, 2017

Do we have the same issue in Go? I.e. is this a porting issue or was the solution broken from the start?

@rogeralsing
Copy link
Contributor Author

rogeralsing commented Mar 27, 2017

Yes, same issue there
We really should have a Proto.Actor meta/design issue tracker

@cpx86
Copy link
Contributor

cpx86 commented Mar 27, 2017

Yeah maybe we should have a new "protoactor" repo for cross-cutting concerns. That could also be used for core documentation that's not specific to any language.

@cpx86
Copy link
Contributor

cpx86 commented Mar 27, 2017

Or we can just repurpose the "gam-web" repo - rename it to "protoactor" and use it for both the website and for general/meta issue tracking.

@rogeralsing
Copy link
Contributor Author

relates to #127

@rogeralsing
Copy link
Contributor Author

This has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants