Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise MessageHeader. #424

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Revise MessageHeader. #424

merged 2 commits into from
Nov 30, 2018

Conversation

potterdai
Copy link
Contributor

@potterdai potterdai commented Aug 6, 2018

  • It's not necessary to regenerate Empty message header every time.
    Since MessageHeader.With already generate a new header object.

  • UnwrapHeader should follow Unwrap, return null instead of MessageHeader.Empty for consistency?

@potterdai potterdai changed the title Revise empty header. Revise MessageHeader. Aug 7, 2018
@rogeralsing rogeralsing merged commit a13d1c7 into dev Nov 30, 2018
@rogeralsing rogeralsing deleted the empty-header branch March 12, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants