Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several revisions #427

Merged
merged 5 commits into from
Nov 30, 2018
Merged

Several revisions #427

merged 5 commits into from
Nov 30, 2018

Conversation

potterdai
Copy link
Contributor

@rogeralsing
This PR contains following changes:

  • Revise Failure type and EscalateFailure method. f11c81e
    1. Follow Go version, add Message Field to Failure message type.
    2. Change EscalateFailure(Exception reason, PID who) to EscalateFailure(Exception reason, object message), since "who" will be ignored anyway.
  • Rename ReceiveMiddleware to ReceiverMiddleware, this is to match SenderMiddleware naming format. 55379d3
  • Move some timer methods to ActorContextExtras. 55cf49b
  • CancelReceiveTimeout when TryRestartOrStopAsync 6361293
    Notice this when compare with Go version. Timer is not cancelled when TryRestartOrStop

@rogeralsing rogeralsing merged commit 8e5e3a1 into dev Nov 30, 2018
@rogeralsing rogeralsing deleted the revise-actor branch March 12, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@potterdai @rogeralsing