Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support chefdk's ruby #22

Merged
merged 1 commit into from Sep 12, 2014
Merged

support chefdk's ruby #22

merged 1 commit into from Sep 12, 2014

Conversation

jtimberman
Copy link
Contributor

Support the embedded Ruby in ChefDK if it is present.

http://www.getchef.com/downloads/chef-dk/

Support the embedded Ruby in ChefDK if it is present.

http://www.getchef.com/downloads/chef-dk/
@jf647
Copy link

jf647 commented Jul 27, 2014

One side-effect of this change is that while /opt/chef/embedded still ends up in RUBIES, there appears to be no way to use it. chruby just lists the last component of the path, and chef-omnibus and chefdk both end in 'embedded':

james@depot:~$ chruby
   ruby-1.9.3-p547
 * embedded
   embedded
james@depot:~$ which ruby
/opt/chefdk/embedded/bin/ruby
james@depot:~$ chruby /opt/chef/embedded
chruby: unknown Ruby: /opt/chef/embedded
james@depot:~$ chruby embedded
james@depot:~$ which ruby
/opt/chefdk/embedded/bin/ruby
james@depot:~$

This isn't a fault of this cookbook, but rather chruby's choice to only let you select on the last component. The PR could simply stop adding /opt/chef/embedded when /opt/chefdk/embedded is present without any change in functionality (and a minor improvement in UX).

There doesn't appear to be any issue open against chruby to allow for specifying the full path to a ruby. I'm not sure if this goes against the philosophy of chruby to allow this (it would add maybe 3 lines to chruby.sh, but that's 3% code bloat. :)

Atalanta pushed a commit that referenced this pull request Sep 12, 2014
@Atalanta Atalanta merged commit f109eb8 into Atalanta:master Sep 12, 2014
@jtimberman jtimberman deleted the support-chefdk branch September 12, 2014 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants