Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Fixes attribution formatting #349

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Conversation

ebetica
Copy link
Collaborator

@ebetica ebetica commented Jun 12, 2020

Implemented all the comments here

Added Yann's name individually to all the files with this command

sed 's/^title:/lecturer: Yann LeCun\ntitle:/' **/week{01,02,03,04,06,07,08,01,11,14}/*-{1,2}.md -i

The only intended difference from the linked comment is that summary pages in different languages have a bar, as well as a translator attribution.

Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll likely have to monitor this in the future, since translations are in progress, and it's likely we've missed a few files.

@Atcold Atcold merged commit ce2d70c into Atcold:master Jun 16, 2020
@ebetica ebetica deleted the fix-attribution branch June 17, 2020 16:52
@Atcold
Copy link
Owner

Atcold commented Jun 19, 2020

What happened to week 09?

@Atcold
Copy link
Owner

Atcold commented Jun 19, 2020

Also, week 04 there was only a lab, no lecture. So, the lecturer is me! Haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants