Fix binder support by adding torchvision, torchtest, and opencv to environment.yml #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As these are required dependancies in the Jupyter notebooks they are needed. Have Binder install libgl1-mesa-glx from apt.txt to add support for opencv. This also fixes Binder being broken.
|
Sweet, thanks. Merging. |
|
@Atcold @ritchieng My apologies if I misunderstood what you were going for, but you closed the PR instead of merging it. |
|
My bad, @matthewfeickert. I got confused by the phone mobile interface. |
|
No worries! |
Atcold
pushed a commit
that referenced
this pull request
Jul 24, 2020
updating from the orginal repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Atcold. I was recently recommending your minicourse but I saw that as the result of recent course development the Binder for it is broken. Specifically,
torchvisionandtorchtextare now used and are not part of the currentenvironment.yml. In addition, in Notebook 10opencvis used. In the notebook you install it in the environment using Jupyter shell magics, but this can't be done in Binder as the user doesn't have access tocondaonce they are in the built image. To fix thisopencvis added toenvironment.ymland anapt.txtfile is added which containslibgl1-mesa-glxfor Binder to install with apt-get to provide some of the OS libraries thatopencvneeds.Please let me know your thoughts on all of this and if you would like any of these changes (or none of them). If you want to try out the new environment in Binder you can try the image built
from my fork(edit: as I deleted my branch this is now the Binder ofmaster):