-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat IP Address as an optional parameter #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please modify the |
ctyano
force-pushed
the
treat_ip_optional
branch
from
March 28, 2024 14:09
366554e
to
73deeae
Compare
@ctyano Do you think we should merge this before the release of v3.2.0? |
I won't do it as I wrote this with expectation of including this PR in v3.2.0. |
This won't be included in v3.2.0 release. |
mlajkim
reviewed
Apr 10, 2024
t4niwa
reviewed
Apr 16, 2024
Co-authored-by: t4niwa <114040262+t4niwa@users.noreply.github.com> Signed-off-by: Tatsuya Yano <ctyano@duck.com>
t4niwa
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IP addresses in X.509 Subject Alternative Names is an optional attribute in Athenz X.509 identity certificate.
Users shall set an empty string to POD_IP environment variable to remove IP address from a CSR.
If the IP address is not set in the CSR, ZTS will skip verifying the client IP address to match the SANs IP. (e.g. InstanceZTSProvider)
Assignees
Assignees
is setType of changes
labels
of the following that fits:bug
: Bug fixdependencies
: Dependency upgradesdocumentation
: Documentation changesenhancement
: New Featuregood first issue
: First contributionlogging
: Log changesrefactor
: Refactoring (no functional changes, no api changes)Flags
Checklist
[skip ci]
/[ci skip]
/[no ci]
/[skip actions]
/[actions skip]
in the PR title if necessaryChecklist for maintainer
Squash and merge
[skip ci]
/[ci skip]
/[no ci]
/[skip actions]
/[actions skip]