Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat IP Address as an optional parameter #117

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Treat IP Address as an optional parameter #117

merged 8 commits into from
Apr 16, 2024

Conversation

ctyano
Copy link
Collaborator

@ctyano ctyano commented Mar 28, 2024

Description

IP addresses in X.509 Subject Alternative Names is an optional attribute in Athenz X.509 identity certificate.
Users shall set an empty string to POD_IP environment variable to remove IP address from a CSR.
If the IP address is not set in the CSR, ZTS will skip verifying the client IP address to match the SANs IP. (e.g. InstanceZTSProvider)

Assignees

  • Assignees is set

Type of changes

  • Apply one or more labels of the following that fits:
    • bug: Bug fix
    • dependencies: Dependency upgrades
    • documentation: Documentation changes
    • enhancement: New Feature
    • good first issue: First contribution
    • logging: Log changes
    • refactor: Refactoring (no functional changes, no api changes)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

@ctyano ctyano added bug Something isn't working enhancement New feature or request labels Mar 28, 2024
@mlajkim
Copy link
Contributor

mlajkim commented Mar 28, 2024

Please modify the athenz-sia.env file too.

@ctyano ctyano requested a review from mlajkim March 28, 2024 13:55
@mlajkim
Copy link
Contributor

mlajkim commented Mar 28, 2024

@ctyano Do you think we should merge this before the release of v3.2.0?

@mlajkim
Copy link
Contributor

mlajkim commented Mar 29, 2024

This requires operation check just in case in k8s platform.
TODOs:
-[x] Operation done by @mlajkim

I won't do it as I wrote this with expectation of including this PR in v3.2.0.

@mlajkim
Copy link
Contributor

mlajkim commented Mar 29, 2024

This won't be included in v3.2.0 release.

@mlajkim mlajkim marked this pull request as draft March 29, 2024 01:45
@mlajkim mlajkim added the release/v3.2.1+ v3.2.1 or higher will include this change label Mar 29, 2024
@mlajkim mlajkim removed the release/v3.2.1+ v3.2.1 or higher will include this change label Apr 8, 2024
ctyano and others added 2 commits April 16, 2024 13:54
Co-authored-by: t4niwa <114040262+t4niwa@users.noreply.github.com>
Signed-off-by: Tatsuya Yano <ctyano@duck.com>
@t4niwa t4niwa marked this pull request as ready for review April 16, 2024 07:30
@t4niwa t4niwa merged commit d9f8bd2 into main Apr 16, 2024
8 checks passed
@t4niwa t4niwa deleted the treat_ip_optional branch April 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants