Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error #101

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Conversation

matteofrigo
Copy link
Contributor

A wrong string formatting was generating an unexpected error. The problem is now fixed.

This PR solves issue #100 .

A wrong string formatting was generating an unexpected error.
The problem is now fixed.
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.06%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   82.79%   82.86%   +0.06%     
==========================================
  Files          67       67              
  Lines        5860     5871      +11     
  Branches      695      696       +1     
==========================================
+ Hits         4852     4865      +13     
+ Misses        819      818       -1     
+ Partials      189      188       -1     
Impacted Files Coverage Δ
...mipy/distributions/tests/test_distribute_models.py 98.86% <90.90%> (-1.14%) ⬇️
dmipy/distributions/distribute_models.py 73.04% <100.00%> (+0.69%) ⬆️
dmipy/distributions/tests/test_bingham.py 91.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd7038...0878f63. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 14, 2020

Pull Request Test Coverage Report for Build 706

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.0009%) to 84.078%

Files with Coverage Reduction New Missed Lines %
dmipy/distributions/tests/test_bingham.py 4 86.3%
Totals Coverage Status
Change from base Build 704: 0.0009%
Covered Lines: 5053
Relevant Lines: 5871

💛 - Coveralls

This commit adds a test for changes introduced in commit 0b502f177ac8cbb63dc2135d170fee58d .
@rutgerfick
Copy link
Collaborator

I notice you also added a test? so it's more than just fixing a sytax error?

@matteofrigo
Copy link
Contributor Author

I added a test to increase the coverage, otherwise it's not going to merge it

@rutgerfick rutgerfick merged commit dcb0916 into AthenaEPI:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants