Multi tissue tortuosity #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the possibility to correct the tortuosity constraint by taking into account the multi-tissue properties of the employed model. In order to do this, the new syntax of the `set_tortuous_parameter` method of the `MultiCompartmentModel` class is extended in such a way that it can take as input the S0 of the tissues modelled by the intra-cellular and the extra-cellular compartments. Backward compatibility is maintained.
This commit adds the raise tests that cover the parsing of the multi tissue correction of the tortuosity constraint. Also, a typo in the filename of the test of the tortuosity function is fixed: tisssue -> tissue.
This commit is responsible for transforming the T1_tortuosity function into a class. This is made necessary by the introduction of the correction of tortuosity constraint in generalized tissue modelling. The corresponding changes in the constraint checks are applied both in the modeling_framework file and in the distribute_models file. Also, this commit solves several pep8 and other minor style issues.
Also, minor flake8 issues have been solved.
The corresponding tests are adapted.
Closed
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 67 67
Lines 5871 5871
Branches 696 696
=======================================
Hits 4865 4865
Misses 817 817
Partials 189 189 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-tissue correction is triggered as follows:
where the trigger is the
S0_correction=True. The used S0 is the one passed to the constructor of the model.Limitations
The stick and the zeppelin must both be at the top level of the model.
Example of admissible model:
This PR replaces #84 .