Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tournier12 White Matter Response Function Estimation #19

Merged
merged 29 commits into from
Sep 17, 2018

Conversation

rutgerfick
Copy link
Collaborator

@rutgerfick rutgerfick commented Aug 30, 2018

  • Includes tournier12 iterative white matter tissue response function estimation
  • Includes peak orientation and amplitude estimation from FODs
  • Includes estimating signal with S0 response.

@rutgerfick rutgerfick changed the title Update README.md Tournier12 White Matter Response Function Estimation Aug 30, 2018
@coveralls
Copy link

coveralls commented Aug 30, 2018

Pull Request Test Coverage Report for Build 309

  • 167 of 219 (76.26%) changed or added relevant lines in 8 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.8%) to 82.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dmipy/core/fitted_modeling_framework.py 22 29 75.86%
dmipy/optimizers_fod/csd_cvxpy.py 4 11 36.36%
dmipy/tissue_response/white_matter_response.py 49 58 84.48%
dmipy/tissue_response/three_tissue_response.py 10 39 25.64%
Files with Coverage Reduction New Missed Lines %
dmipy/data/saved_data.py 2 70.94%
dmipy/distributions/tests/test_bingham.py 2 93.15%
dmipy/data/saved_acquisition_schemes.py 2 83.33%
dmipy/utils/tests/test_spherical_convolution.py 4 88.37%
Totals Coverage Status
Change from base Build 266: -0.8%
Covered Lines: 4338
Relevant Lines: 5099

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #19 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   83.22%   83.18%   -0.05%     
==========================================
  Files          55       55              
  Lines        4824     4824              
  Branches      543      543              
==========================================
- Hits         4015     4013       -2     
- Misses        667      668       +1     
- Partials      142      143       +1
Impacted Files Coverage Δ
dmipy/distributions/tests/test_bingham.py 95.52% <0%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b4985...e0352c3. Read the comment docs.

@rutgerfick
Copy link
Collaborator Author

fix peaks estimator.

@rutgerfick
Copy link
Collaborator Author

seems to work, add small test for tournier07 and some parts of 3 tissue algorithm and merge.

@rutgerfick
Copy link
Collaborator Author

Update 3 tissue response catches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants