Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes spherical mean print and fixes dhollander docstring #80

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

rutgerfick
Copy link
Collaborator

Closes #79 and closes #75

@coveralls
Copy link

coveralls commented Oct 1, 2019

Pull Request Test Coverage Report for Build 585

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 82.683%

Files with Coverage Reduction New Missed Lines %
dmipy/utils/tests/test_spherical_convolution.py 1 95.35%
dmipy/distributions/tests/test_bingham.py 4 89.04%
Totals Coverage Status
Change from base Build 581: 0.08%
Covered Lines: 4696
Relevant Lines: 5539

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #80 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   81.76%   81.76%   -0.01%     
==========================================
  Files          64       64              
  Lines        5540     5539       -1     
  Branches      653      653              
==========================================
- Hits         4530     4529       -1     
  Misses        838      838              
  Partials      172      172
Impacted Files Coverage Δ
dmipy/utils/spherical_mean.py 100% <ø> (ø) ⬆️
dmipy/tissue_response/three_tissue_response.py 35.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980f439...c39d359. Read the comment docs.

@rutgerfick rutgerfick merged commit 04fb836 into master Oct 1, 2019
@rutgerfick rutgerfick deleted the remove_print branch October 1, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

probably unwanted print spherical mean order of output in three_tissue_response_dhollander16
3 participants