Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category selector doesn't show hierarchy #1045

Closed
Jorengarenar opened this issue Mar 6, 2023 · 6 comments
Closed

Category selector doesn't show hierarchy #1045

Jorengarenar opened this issue Mar 6, 2023 · 6 comments

Comments

@Jorengarenar
Copy link
Contributor

Let's assume the following example hierarchy of categories:

  • Foo
    • Bar
  • Bar

If I want to add new feed/category under Bar, both Bar and Foo/Bar are shown in dropdown menu just as Bar

@Athou Athou added this to the 3.0 milestone Mar 7, 2023
@Athou
Copy link
Owner

Athou commented Mar 7, 2023

Ah yes, in CommaFeed 2.0 I was displaying "Bar (in Foo)" to avoid this problem. I forgot to port it back.

@Jorengarenar
Copy link
Contributor Author

Jorengarenar commented Mar 7, 2023

Better, but there are still problems:

  • Foo
    • Bar
      • Baz
  • Bar
    • Baz

Both Baz are displayed as Baz (in Bar)

Perhaps something a la tree would be better? Or at least Foo / Bar / Baz

@Athou
Copy link
Owner

Athou commented Mar 7, 2023

Sure, but maybe later then :) It's been like this for almost ten years I just wanted to quickly fix the regression.

@Athou Athou removed this from the 3.0 milestone Mar 7, 2023
@Athou Athou closed this as completed in 5003c17 Apr 25, 2023
@Jorengarenar
Copy link
Contributor Author

Jorengarenar commented Apr 25, 2023

@Athou
Is this issue fully fixed? I still see both Baz displayed as Baz (in Bar)

@Athou
Copy link
Owner

Athou commented Apr 25, 2023

No, it's not. Github closed the issue during the merge of develop into master because there was a "fix #1045" in the comment message.

@Athou Athou reopened this Apr 25, 2023
Athou added a commit that referenced this issue Jan 8, 2024
@Athou
Copy link
Owner

Athou commented Jan 8, 2024

Done! It was actually easier than I thought it would 😄

@Athou Athou closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants