Use CANEN instead of CANCDMOB to check if MOB is free #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using only CANCDMOB is subject to race conditions, for example when no nodes are ACKing. Fixes Atlantis-Specialist-Technologies#7.
astrand
force-pushed
the
canen-not-cancdmob
branch
from
9a3e277
to
dfa526e
Compare
|
The earlier implementation from 2020-05-29 had a race condition; fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CANCDMOB is subject to race conditions, for example when no
nodes are ACKing.
Fixes #7.