Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Facilitator Certification Date doesn't update if it is to an earlier date (or deleted) #508

Closed
atlasjen opened this issue Dec 21, 2023 · 5 comments
Assignees
Labels
bug Something isn't working verified verified in staging wontfix This will not be worked on

Comments

@atlasjen
Copy link
Contributor

I believe the issue is

  1. if a file is removed the Last * Date isn't cleared or rolled back to the previous last date
  2. if a file's date is updated that was older than the previous last date, the last date isn't updated.

Here is the use case.
This is on Madeline Jill Mohr's record in prod. (release 1.5)

Laura accidentally uploaded a Trainer Certification document and used the Team Facilitator type.
It had a date of 12/12/23.

There previously had been a Facilitator Certification document w/ the Team Facilitator type.. It had a date of 7/25/23.
image

As a result the Last Facilitator Certification Agreement date was stomped on and changed to 12/12/23. That is expected proper behavior.

To attempt to fix this, I had her:

  1. change the type on the most recent team facilitator one to trainer and save. That fixed the last trainer certification date.
  2. try to change the date on the other team facilitator one by a day or so and save to see if it would trigger an update to the Last Facilitator Date. It changes the document date that is shown in the related file list, but the Last Facilitator Certification Agreeement date isn't changing.

image

image

She also tried deleting the Team Facilitator Agreement.
That means, the date should have rolled back to the most recent one there
image

However, when i go look at position details (after refresh), this is what i see (it didn't clear the date or reset it)
image

I then upload the doc again but nothing changes in related.

@atlasjen atlasjen added the bug Something isn't working label Dec 21, 2023
@atlasjen atlasjen added this to the Release 1.6 milestone Dec 21, 2023
@deb761
Copy link
Collaborator

deb761 commented Dec 23, 2023

I'm concerned that any fix would wind up pushing the trigger over the SQL query limit. I'll try it out, but why didn't you tell her to just set the correct date in the Last Facilitator Certification Agreement field?

@atlasjen
Copy link
Contributor Author

atlasjen commented Dec 23, 2023 via email

@atlasjen
Copy link
Contributor Author

atlasjen commented Jan 8, 2024

what did we decide to do with this?

@deb761
Copy link
Collaborator

deb761 commented Jan 8, 2024

Update the date manually in these situations, as the trigger solution is too query intensive.

@atlasjen
Copy link
Contributor Author

atlasjen commented Jan 8, 2024

ok. closing.

@atlasjen atlasjen closed this as completed Jan 8, 2024
@atlasjen atlasjen added wontfix This will not be worked on verified verified in staging labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified verified in staging wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants