fix: dockerfile #118
Merged
fix: dockerfile #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luludotdev
requested review from
Auros,
sc2ad,
nike4613 and
a team
as code owners
Caeden117
approved these changes
Sep 8, 2023
the docker workflowhad an issue with submodules, since been fixed the .net workflow seems to have an issue with whoever wrote it failing to account for it running on external pull requests, as it is trying to log in as me to publish packages, which is obviously failing because I do not have the required permissions |
|
We can ignore that step when building PRs. I can make a separate PR for that soon. I'm not sure if we want every single incoming PR to be published to NuGet? |
sc2ad
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimises dockerfile build steps, improves the github actions workflow, and solves the core plugins issue