Ability to have custom login messages as OPs #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focusvity
reviewed
Jan 15, 2022
There was a problem hiding this comment.
- The suggestion hasn't been approved, so the PR will not proceed any further until the suggestion has been approved and a ticket has been raised on Jira.
- Players should be able to pick login messages from GUI or create their own via
/loginmessage <message>(should the suggestion be approved). - The message should be restricted to a certain number of characters - 100 is too high.
| @@ -10,7 +10,7 @@ | |||
| import org.bukkit.entity.Player; | |||
|
|
|||
| @CommandPermissions(level = Rank.OP, source = SourceType.ONLY_IN_GAME) | |||
| @CommandParameters(description = "Change your login message", usage = "/<command> [message]") | |||
| @CommandParameters(description = "Change your login message", usage = "/<command> <message>") | |||
There was a problem hiding this comment.
This should stay as optional - /loginmessage will open up the premade login messages (in an inventory)
| @@ -24,11 +24,10 @@ public boolean run(final CommandSender sender, final Player playerSender, Comman | |||
|
|
|||
| if (args.length == 0) | |||
| { | |||
| playerSender.openInventory(plugin.sh.generateLoginMessageGUI(playerSender)); | |||
| msg("You must set a valid login message! Usage: /<command> <message>", ChatColor.RED); | |||
There was a problem hiding this comment.
See my previous post - /loginmessage opens up the login message GUI, allowing people to choose the available login messages. All you did was remove the ability to do so and force people to set their own.
Wild1145
added
the
Pending Jira Ticket
|
Closing due to inactivity |
Focusvity
added
wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements this suggestion.