Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Project > Organisation list is missing due to read timeout. #686

Closed
sat01a opened this issue Sep 2, 2016 · 6 comments
Closed

New Project > Organisation list is missing due to read timeout. #686

sat01a opened this issue Sep 2, 2016 · 6 comments
Assignees
@sat01a @javier-molina
Labels
Type - bug

Comments

@sat01a
Copy link
Contributor

sat01a commented Sep 2, 2016

2016-09-02 16:01:28,511 ERROR [WebService] {error=Timed out getting json. URL= https://ecodata-test.ala.org.au/ws/organisation.}
3572 java.net.SocketTimeoutException: Read timed out
3573 at java.net.URLConnection.getContent(URLConnection.java:739)
@nickdos
Copy link
Contributor

nickdos commented Sep 4, 2016

Is this an issue with ecodata or is it flowing through to an issue in collectory?

@sat01a
Copy link
Contributor Author

sat01a commented Sep 5, 2016 •
edited

Its a BioCollect issue.
It's fetching all organisation details instead of paginating it.

sat01a added a commit that referenced this issue Sep 5, 2016
@sat01a
#686 New Project > Organisation list is missing due to read timeout.
6de1612 
Temp fix.
@javier-molina javier-molina self-assigned this Dec 4, 2016
@javier-molina
Copy link
Contributor

javier-molina commented Dec 4, 2016 •
edited

Organisation pagination as implemented in MERIT:

https://fieldcapture-test.ala.org.au/organisation/list
https://github.com/AtlasOfLivingAustralia/fieldcapture/blob/master/grails-app/views/organisation/list.gsp
https://github.com/AtlasOfLivingAustralia/fieldcapture-hubs/blob/master/fieldcapture-hubs-plugin/web-app/js/organisation.js#L230

http://biocollect.ala.org.au/organisation/list;jsessionid=6A9A14A7C20346EEF2E4A67D5E1BB184

@javier-molina
Copy link
Contributor

An example of the issue, even caused when displaying a single project

==> biocollect.log <== 2016-12-08 12:28:55,310 ERROR [WebService] {error=Timed out getting json. URL= https://ecodata-test.ala.org.au/ws/organisation.} java.net.SocketTimeoutException: Read timed out at java.net.URLConnection.getContent(URLConnection.java:748) at au.org.ala.biocollect.merit.WebService.responseText(WebService.groovy:202) at au.org.ala.biocollect.merit.WebService.getJson(WebService.groovy:164) at au.org.ala.biocollect.merit.MetadataService$_organisationList_closure19.doCall(MetadataService.groovy:211) at au.org.ala.biocollect.merit.CacheService.get(CacheService.groovy:31) at au.org.ala.biocollect.merit.MetadataService.organisationList(MetadataService.groovy:210) at au.org.ala.biocollect.merit.ProjectController.index(ProjectController.groovy:179) at grails.plugin.cache.web.filter.PageFragmentCachingFilter.doFilter(PageFragmentCachingFilter.java:198) at grails.plugin.cache.web.filter.AbstractFilter.doFilter(AbstractFilter.java:63) at au.org.ala.cas.client.UriFilter.doFilter(UriFilter.java:200) at au.org.ala.cas.client.UriFilter.doFilter(UriFilter.java:200) at au.org.ala.cas.client.UriFilter.doFilter(UriFilter.java:200) at org.jasig.cas.client.session.SingleSignOutFilter.doFilter(SingleSignOutFilter.java:110) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.read(SocketInputStream.java:152) at java.net.SocketInputStream.read(SocketInputStream.java:122) at java.io.BufferedInputStream.fill(BufferedInputStream.java:235) at java.io.BufferedInputStream.read1(BufferedInputStream.java:275) at java.io.BufferedInputStream.read(BufferedInputStream.java:334) at java.net.URLConnection.getContentType(URLConnection.java:522) at au.org.ala.biocollect.merit.WebService.responseText(WebService.groovy:197) ... 14 more

javier-molina pushed a commit that referenced this issue Dec 8, 2016
#686
bf7cf90 
- Progress checkin
- All UI elements for organisation selection working
- TODO
	- Add required validation
        - Remove old controls
	- Make sure the organisation field can indeed be saved
	- Update remaining organisation fields
	- Make sure metadataService.organisationList() can safely be deleted.
javier-molina pushed a commit that referenced this issue Dec 13, 2016
#686
bd2ce77 
- Running organisation and associated organisations drop down replaced with ES paginated results.
- TODO
  - Grantee and Sponsoring organisation plus other back end changes.
javier-molina pushed a commit that referenced this issue Dec 14, 2016
#686
e491e83 
- Converted Grantee and Sponsor organisations
- TODO:
  - Stop passing organisations as part of the model for project pages
javier-molina pushed a commit that referenced this issue Dec 16, 2016
#686
3f54cce 
- Removing all references to full organisation list
- Remove now unused MetadataService organisation operations
@javier-molina
Copy link
Contributor

javier-molina commented Dec 16, 2016 •
edited

#710

https://upsource.ala.org.au/ecodata/review/ECODATA-CR-71
https://upsource.ala.org.au/biocollect/review/BIOCOLLECT-CR-201

javier-molina pushed a commit that referenced this issue Dec 18, 2016
#686
4a7ecd2 
Fixed failing tests
javier-molina pushed a commit that referenced this issue Dec 19, 2016
#686
1bfd6e2 
- Unit test no longer relevant
@sat01a sat01a self-assigned this Dec 20, 2016
@sat01a
Copy link
Contributor Author

sat01a commented Dec 20, 2016 •
edited

screen shot 2016-12-20 at 2 15 34 pm

  1. Can we remove empty organisation from the list?
  2. Register new organisation doesn't seems to work.

screen shot 2016-12-20 at 2 26 57 pm

javier-molina pushed a commit that referenced this issue Dec 20, 2016
#686
ccff8df 
- Addressing review comments
- Empty organisations fixed
- Create organisation button fixed
- Added create organisation checkbox and button for grantee and sponsor organisations too.
- Fixed additional issue with amplify.store when loading and empty project key.
@sat01a sat01a closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sat01a sat01a

@javier-molina javier-molina

Labels
Type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickdos @sat01a @javier-molina