Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect_media() errors and stops if a thumbnail is missing #215

Closed
shandiya opened this issue Nov 29, 2023 · 2 comments
Closed

collect_media() errors and stops if a thumbnail is missing #215

shandiya opened this issue Nov 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@shandiya
Copy link
Contributor

Describe the bug
collect_media() errors and stops if thumbnails are missing when full-sized images exist. The error message returned is:

Error in `map()`:■■■■■■■■■■                    45% |  ETA:  3s
ℹ In index: 15.
Caused by error in `req_perform()`:
! HTTP 403 Forbidden.

galah version
2.0.0

To Reproduce

z <- galah_call() |> 
  galah_identify("Candovia aberrata") |>
  galah_filter(year == 2023) |>
  atlas_media()

z_media <- collect_media(z, thumbnail = TRUE)

Expected behaviour
Ideally it would be helpful if a default value of NULL or something similar is returned when a thumbnail is missing, and the looping across remaining records continues.

@shandiya shandiya added the bug Something isn't working label Nov 29, 2023
daxkellie added a commit that referenced this issue Nov 29, 2023
* Thumbnail downloads trigger `req_perform` sequence with error handling
* `collect_media` provides message of number of failed files to download too
@daxkellie
Copy link
Contributor

Fixed in galah 2.0.1

@daxkellie daxkellie reopened this Mar 20, 2024
@daxkellie
Copy link
Contributor

consider whether we can make test for this. might be tough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants