Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Get-WikiPage #53

Closed
JohnLBevan opened this issue May 26, 2017 · 2 comments
Closed

Refactor Get-WikiPage #53

JohnLBevan opened this issue May 26, 2017 · 2 comments

Comments

@JohnLBevan
Copy link

The code used to determine what columns are returned from Get-WikiResults has a lot of duplication.
Refactor to reduce duplication / make it more apparent what the differences are for each condition.

JohnLBevan pushed a commit to JohnLBevan/ConfluencePS that referenced this issue May 26, 2017
@brianbunke
Copy link
Collaborator

Hello, and welcome!

@lipkau has drastically refactored the module in the develop branch. It's currently waiting for me to go through everything, raise needed issues, fill in any missing docs, and release as new version 2.0. Sorry this isn't immediately obvious right now 😞...hopefully it's a very short term problem before the release happens.

As we're basically working off of develop and raising issues against it at this point, I'm going to close this out. Happy to answer any follow-up questions, though!

@JohnLBevan
Copy link
Author

Ah no worries; thanks for the note.
I'll work off the dev branch for #50 .

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants