Switching to ConvertFrom-Json2 #23
Conversation
OOB ConvertFrom-Json implementation does not allow for overriding JSON maxlength. Default is easy to exceed with large issue lists. Change adds a ConvertFrom-Json2 function which allows override of maxlength, sets the default to Max(int) and replaces all calls to ConvertFrom-Json with ConvertFrom-Json2
Added an extra 2 ad the end of the function name, doh.
|
I probably should have run the test suite myself first, works fine with the Jira-Issue but breaks other functions. I blame Friday. Just updating the code now to play nice. Another commit forthcoming. |
A couple of the other functions rely on expanded types so replicating expanded types functionality in PS.
|
Hi! Sorry this is a bit delayed; I've had some life changes recently that have affected my ability to work on this module. Your ConvertFrom-Json2 function is super cool (honestly, that was the biggest thing keeping me on PS 3.0; I didn't want to rewrite the JSON cmdlets). Thanks for correcting the Pester test as well. I don't have the ability to test this live against a JIRA instance right now. Can you confirm that with your change, the module still seems to be performing correctly (creating / resolving / editing issues and such)? |
|
Confirming all is working as expected against a live JIRA instance. On Sun, Apr 3, 2016 at 8:58 PM, Joshua T notifications@github.com wrote:
Liam Leane Email: lleane.work@gmail.com |
|
Great. Thanks for the contribution! |
OOB ConvertFrom-Json implementation does not allow for overriding JSON
maxlength. Default is easy to exceed with large issue lists.
Change adds a ConvertFrom-Json2 function which allows override of
maxlength, sets the default to Max(int) and replaces all calls to
ConvertFrom-Json with ConvertFrom-Json2