Skip to content

Move blocking handleMessageEvent to executer thread to keep pipeline reactive #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arooba-git wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move blocking handleMessageEvent to executer thread to keep pipeline reactive #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions server/src/main/java/org/atmosphere/nettosphere/BridgeRuntime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.Callable;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.Future;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.*;

@jfarcand jfarcand Jul 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Do not use *

import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;

Expand All @@ -123,6 +118,7 @@
@Sharable
public class BridgeRuntime extends HttpStaticFileServerHandler {

private final ExecutorService executor = Executors.newSingleThreadExecutor();

@jfarcand jfarcand Jul 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this optional, and the Thread pool configuration and optional. Making it the default change the current behaviour, and we will have to bump to a major version 4.0.0

public static boolean NETTY_41_PLUS;

static {
Expand Down Expand Up @@ -294,15 +290,21 @@ public AtmosphereFramework framework() {

@Override
public void channelRead(final ChannelHandlerContext ctx, final Object messageEvent) throws URISyntaxException, IOException {
try {
handleMessageEvent(ctx, messageEvent);
} finally {
if (messageEvent instanceof ReferenceCounted) {
ReferenceCounted refMsg = (ReferenceCounted) messageEvent;
if (refMsg.refCnt() > 0)
refMsg.release();
executor.execute(() -> {
try {
handleMessageEvent(ctx, messageEvent);
} catch (URISyntaxException e) {
throw new RuntimeException(e);
} catch (IOException e) {
throw new RuntimeException(e);
} finally {
if (messageEvent instanceof ReferenceCounted) {
ReferenceCounted refMsg = (ReferenceCounted) messageEvent;
if (refMsg.refCnt() > 0)
refMsg.release();
}
}
}
});
}

private void handleMessageEvent(final ChannelHandlerContext ctx, final Object messageEvent) throws URISyntaxException, IOException {
Expand Down