Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Remove messages from all bindings #24

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

Arcanemagus
Copy link
Member

@Arcanemagus Arcanemagus commented Sep 18, 2017

Properly queue up messages for removal, and then remove from all bindings at once. Before this it was possible for a message to be removed from one binding and then get "stuck" in other bindings as it was already marked as removed.

Before this you could get a message "stuck" by:

  1. Open a file
  2. Trigger a message on the file
  3. Split the file so there are two instances open for it
  4. Trigger a second, new, message in the file
  5. Fix both messages
  6. Note that the initial message is still showing for the second view on the file

Properly queue up messages for removal, and then remove from all
bindings at once. Before this it was possible for a message to be
removed from one binding and then get "stuck" in other bindings as it
was already marked as removed.
@Arcanemagus Arcanemagus merged commit 9c9f751 into master Sep 18, 2017
@Arcanemagus Arcanemagus deleted the arcanemagus/better-message-removal branch September 18, 2017 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant