Update to Linter 3 + fixes the messages not being updated #82
Conversation
|
@Arcanemagus Could you review this? |
There was a problem hiding this comment.
The commits either need to be squashed into a single commit for these changes, or they need to be re-ordered so that each commit comes in a sensible order. As it stands right now you have many commits that are dependent on changes in commits that come after them.
These commits are all currently tagged with feat: when they should be fix: since nothing has actually changed with linter, this is just fixing a bug here.
Other than that these changes look good.
You can squash and merge the commits with your preferred message.
|
Now that messages are being tracked separately from the marker keys they need to be cleared as well on disposing of the binding.
Take the repeated code for redecorating all markers and move it to a class function.
Remove an unused private variable, probably copied from the main package.
This updates minimap-linter so it is in sync with linter 3 changes. It fixes the messages not being updated after changes.
The issue of minimap-linter was because JavaScript cannot compare complex objects well, and so
Set.add(message)orSet.delete(message)do not add/delete messages! I changed the code to useMapwith my customkey(message.key).