Default Config & Disable If No Project Config settings #101
Conversation
What other provider does this?
Awesome! Reviewing this now. |
Sorry, I thought linter-eslint defaulted to that directory but that is just what I have it set to. This would be |
src/index.js
Outdated
| defaultConfig: { | ||
| title: 'Default Config Path', | ||
| type: 'string', | ||
| default: atom.getConfigDirPath(), |
There was a problem hiding this comment.
I would just leave this blank, if a user wants to fill this in they can enter the path to wherever it should be themselves. The default value as is is wrong and just encourages people to put non-Atom configuration files in there.
src/index.js
Outdated
| @@ -17,6 +17,19 @@ const loadDeps = () => { | |||
| }; | |||
|
|
|||
| module.exports = { | |||
| config: { | |||
| defaultConfig: { | |||
| title: 'Default Config Path', | |||
There was a problem hiding this comment.
I'd add a description clarifying that this is only used if coffeelint can't find a configuration on it's own.
|
I updated it to look more like linter-eslint |
|
This sounds like a good update - can someone with access merge it? |
|
Whoops, this got lost in my notifications. @UziTech would you be interested in being added as a maintainer here? |
|
That sounds great 😃👍 |
|
Added, feel free to merge this whenever 😉. Please don't hesitate to contact me on Atom's Slack, as you can see sometimes it takes a while for me to get to a GitHub notification 😆. |
|
@Arcanemagus sounds good. Is there a process for pushing a new version to APM? |
|
You can update the changelog using Alternatively you can:
Since you aren't signing your commits, the first option is probably easier. Also, I just started a discussion in the team area about automating the entire process that needs some feedback 😉. |
Adds settings to use a default config if no project config is found. The default setting is
~/.atomlike other linters.I also added a checkbox to disable coffeelint if no project config is found.
closes #98