Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Improve Atom startup time #75

Merged
merged 2 commits into from
Nov 19, 2016

Conversation

walles
Copy link
Contributor

@walles walles commented Nov 18, 2016

Before this change, activation was done on Atom startup, whether or not
you actually had any CoffeeScript files open.

With this change in place, we postpone activation until the Atom
CoffeeScript grammar's first use.

This improves startup time of my Atom by about 29ms, thus fixing one of
the top startup time offenders according to TimeCop.

For some frame of reference, I have 87 packages installed, and Timecop
lists all packages with startup times above 5ms.

Before this change, activation was done on Atom startup, whether or not
you actually had any CoffeeScript files open.

With this change in place, we postpone activation until the Atom
CoffeeScript grammar's first use.

This improves startup time of my Atom by about 29ms, thus fixing one of
the top startup time offenders according to TimeCop.

For some frame of reference, I have 87 packages installed, and Timecop
lists all packages with startup times above 5ms.
Copy link
Member

@AsaAyers AsaAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
I'll merge once all the tests finish.

@AsaAyers AsaAyers merged commit 6f61923 into AtomLinter:master Nov 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants