This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Don't rely on screen rows and respect offsets #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen buffer only counts unfolded lines so line numbers do not match actual buffer lines.
|
Checking over. |
|
I wish there was a way to do this using the public API, but I can't figure out a way looking over it. LGTM, merging! Btw, would you be interested in becoming a maintainer for this package? |
Arcanemagus
added a commit
that referenced
this pull request
Dec 16, 2015
Don't rely on screen rows and respect offsets
|
If you have a bug you'd like me to look at, I am happy to help but I think I maintain enough software already 😉 |
|
No problem and thanks for helping out 😉. Published in v1.9.3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen buffer only counts unfolded lines so line numbers do not match actual buffer lines.
Fixes #99
Fixes #126