Add support to default config files

[gpiress]

This PR tries to load the tox.ini file for loading linting rules.

The order of precedence is:

• Tries to load projectConfigFile if set
• Tries to load tox.ini if it exists
• Loads default configurations

The idea behind this is that if a project already has a tox.ini
file, it should try to use unless overriden. This works similar
to when flake8 is run in the command line.

Fixes #124.

[gpiress]

I don't really get the error message, seems unrelated to the changes.

Local runs of npm run lint and npm run test work fine, is there
anything else that I should look out for?

[Arcanemagus]

Bizarre, the projectConfigFile setting already exists to handle this, however it looks like the defaults were left blank. If I remember correctly flake8 at least used to run it's own config search if you didn't specify a --config option, if that is no longer the case then the default for projectConfigFile should just be updated to the names of config files that flake8 will load on it's own instead of introducing a hidden search.

Note the CI failure is due to a change in Atom and is unrelated to this PR.

[gpiress]

@Arcanemagus currently, if the projectConfigFile is not explicitly set in the package settings page, the package does not apply the rules specified in tox.ini.

I'll update the PR to default projectConfigFile to the files that flake8 uses when running it from the command line.

[gpiress]

@Arcanemagus So, I updated the PR with the suggested changes.

Now it checks if the projectConfigFile is set, if it isn't, it looks for the patterns that flake8 looks for (tox.ini, .flake8 and setup.cfg, according to the docs).

I tested it out using all three different default config files, it works for all of them.

If the user sets the projectConfigFile, in the package settings, it overrides every other rule and uses that one.

If no config file is set and no default config file is found, it uses the default rules.

[Arcanemagus]

Sorry, I literally meant change the default value here, that way instead of having a hidden default users can see explicitely what is being searched for and add/remove from it as they desire.

[gpiress]

Oh, okay :)

First time dealing with atom packages, didn't even think of looking there :)

[gpiress]

Okay, this should do the trick now :)

Tested it locally and worked out.

[Arcanemagus]

Marked this as fixing #124, since it likely will.

[Arcanemagus]

Published in v2.3.0 🎉