Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Support inline <script> #110

Closed
didrocks opened this issue Sep 17, 2015 · 7 comments · Fixed by #180
Closed

Support inline <script> #110

didrocks opened this issue Sep 17, 2015 · 7 comments · Fixed by #180

Comments

@didrocks
Copy link

As Polymer and other web components frameworks have a lot of inline script tags, it would be nice for linter-jscs to be able to parse them as well, as linter-jshint is doing.
However, adding the source.js.embedded.html scope isn't enough as there is the need for jscs-dev/node-jscs#1038 to land (unsure how extracting will then play with inline save feature though).

@tehapo
Copy link

tehapo commented Oct 29, 2015

I'm also interested in this functionality. Seems that the jscs-dev/node-jscs#1038 is already merged.

@teddybradford
Copy link

This would be awesome!

@decademoon
Copy link

👍

@Arcanemagus
Copy link
Member

A PR implementing this would be great, it doesn't look like this package currently has an active maintainer.

@aminnaggar
Copy link

👍

@dulrich
Copy link
Contributor

dulrich commented Feb 9, 2016

I don't have a pull-request yet because it probably needs an option for "Lint inline JavaScript", and potentially my code should be cleaned up.

The result.sources.forEach loop is essentially the same as the one in Checker, overall it's a small addition to check inline script tags. [commit]

ETA: requiring extractJs directly from jscs seems to work;

@Arcanemagus
Copy link
Member

If linting that is entirely self contained (nothing external needed), I don't really see a reason to put it behind an option myself.

We aren't currently allowing the use of a project's built in jscs, so we don't have to worry about support not being there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants