Latest 1.1.1release seems to no longer recognize .jshintrc in project

[trevordmiller]

The latest 1.1.1 release (I updated in Atom today) seems to no longer recognize the .jshintrc settings in my projects: I am gettting linter errors/warnings that don't line up with my .jshintrc settings (see screenshot below). It has been working for me for months (no code changes) until this last update.

[steelbrain]

Super-weird, the only update in this release was that it uses atom as the nodejs runtime instead of the system installed one, can you try to hard-code the jshint path in settings and see if it fixes it for you?

[trevordmiller]

@steelbrain How can I hard code the Path of the jshint executable if it is different for every project? I almost always have a .jshintrc at the root of each project I work on...

[steelbrain]

Dynamic for each project? I don't understand. It's actually the same IMO

[trevordmiller]

@steelbrain So, instead of having one master .jshintrc in my user directory / atom package that every project points to, I usually have a .jshintrc at the root of each project which may or may not be the same...just as you can have other configuration files at the root of a project that may be different for each project on your machine (ie .editorconfig, .gitignore, .npmrc, package.json etc.). I believe this is a really common pattern that many GitHub projects use not only for JSHint but for ESLint (.eslintrc), JSCS (.jscsrc), JSLint (.jslintrc) etc. Here are a few examples from popular projects:

• Gulp: https://github.com/gulpjs/gulp
• Grunt: https://github.com/gruntjs/grunt
• jQuery: https://github.com/jquery/jquery

Make sense?

[steelbrain]

I know what the problem is. Gonna fix it soon!

[Glavin001]

Also experiencing this. esnext option as well.

[ghost]

For those having this problem, install version 1.1.0:

apm uninstall linter-jshint && apm install linter-jshint@1.1.0

And then if you have any problem with the jshint/node executable (when linting), add this to your atom init file:

process.env.PATH = ["/usr/local/bin", process.env.PATH].join(":")

Workaround for now or just revert back to 1.0.

[trevordmiller]

@peduxe Thanks for the tip. Reverting back and adding the the environment path to my init file worked great for me.

[steelbrain]

Thanks @peduxe 👏

[adamreisnz]

Just wanted to raise this issue as well, as suddenly my node files were throwing jshint errors on undefined require's. Good to see you're already on it, thanks!

[nathanbuchar]

Yep, same here! Looks like it's already being tackled—thanks! :-)

[giannisp]

Same issue here, until the update, apm uninstall linter-jshint && apm install linter-jshint@1.1.0 worked just fine for me.

[steelbrain]

I have tracked it down to this line

return helpers.execNode(executablePath, parameters, {stdin: text}).then (output) ->

if you change it to

return helpers.exec(executablePath, parameters, {stdin: text}).then (output) ->

it works, which means that detection is working via global nodejs and not working via electron.

[steelbrain]

The error seems to be in node_modules/jshint/src/cli.js line 615, the value of config is different if run via normal iojs or electron.

[joefitzgerald]

@steelbrain I'm not sure that modifying the environment in the atom init file is the right solution here. For one thing, it'll break the detection logic in https://atom.io/packages/environment should we decide to integrate it.

[steelbrain]

@joefitzgerald but it should still work this way, for users who don't have nodejs installed at all.

[joefitzgerald]

I'm saying we shouldn't be instructing people to add /usr/local/bin to their path in atom's init file. I'm not commenting on other aspects of your solution.

[steelbrain]

@joefitzgerald for linter-jshint, users don't have to install anything, it's bundled with this package, and uses electron as it's node runtime 😉

[joefitzgerald]

Consider consuming the service provided by environment, and using that for the environment that you pass to execNode. If you don't allow the caller of execNode to specify the environment then you need to make that configurable.

[joefitzgerald]

But yes, I understand that jshint is bundled and the embedded node that Atom uses should suffice. My comments simply apply to ensure use of global node (if required) will work.

[steelbrain]

We don't really need node, anywhere in this project 😅