-
Notifications
You must be signed in to change notification settings - Fork 39
Reintroduce json linting? #18
Comments
@JakeKIT Nope, json shouldn't be linted with jshint. But with https://github.com/zaach/jsonlint ;) I'll do a json-linter soon. |
@iam4x, @JakeKIT already done it https://github.com/AtomLinter/linter-jsonlint |
I think this is weird behaviour. jshint in our gulpfile lints json files, and I installed this package specifically so I could find all the problems before it got that far. Why doesn't linter-jshint just do what jshint does, instead of deciding for jshint what it should and shouldn't do |
Because JSHint doesn't actually say that it lints JSON, so this package doesn't make it do so. If you want JSON linting you should install a JSON lint provider such as linter-jsonlint. The "JSON linting" that is done by JSHint is actually just a wrapper around an old version of that anyway, and as far as I knew only happened on |
It's true that it's not advertised as a feature for jshint, but I found it jarring that their behaviours are different. I've installed linter-jsonlint now, but my opinion is still that this package should match jshint. The file that was linted by jshint for me was a not a |
As JSHint doesn't advertize support for that I'm not enabling it. JSHint is buggy enough linting just JS code I don't really want to deal with issues from it linting JSON when they don't even officially support it. |
Looks like steelbrain/linter#39 was caused by steelbrain/linter#67 and not by using jshint to lint json with the react editor. Thoughts on bringing it back?
The text was updated successfully, but these errors were encountered: