-
Notifications
You must be signed in to change notification settings - Fork 39
"Lint JSX Files" doesn't seem to work #331
Comments
That option simply toggles running on files identified by the It used to change a flag passed to JSHint, but at some point they brought support for that into the main linter process by default, so it doesn't change the behavior of the linter at all. Do you see the same results when running JSHint from the CLI? |
Yes, good point - although I don't see any reference on jshint.com of supporting JSX.. there is a link at the bottom of the Install page (under Other cool stuff) to https://github.com/CondeNast/JSXHint (which in turn links to https://github.com/STRML/JSXHint/) which makes me think that jshint doesn't actually claim to work for JSX? |
It's quite possible. I know it is very buggy with it. You should probably look into using ESLint with the JSX options enabled, see https://www.npmjs.com/package/eslint-plugin-react for an example of how to set that up. |
Thanks :) I've actually already switched to that on projects using JSX, but even after removing the Don't you think you should remove this option from the atom package settings since it definitely doesn't work and probably never will? |
Generally I'd leave that up to the package maintainer... but it seems this package has no active maintainer so I'd go for that. |
The "Lint JSX Files" option doesn't seem to work at all - any jsx at all results in a
E015 - Unclosed regular expression
Also, it's not clear how it's meant to work - is it just based on file extension?
The text was updated successfully, but these errors were encountered: