Add Rubocop --autocorrect functionality (#187)

* Rename to .js and move to src

* Change to ES6 and add --autocorrect

* Switch build to Babel and consolidate ES6

* Wait for rubocop.yml asyncronously

package.json

@@ -1,31 +1,45 @@
 {
   "name": "linter-rubocop",
-  "main": "./lib/index.coffee",
+  "main": "./src/index.js",
   "version": "0.5.3",
   "description": "Lint Ruby on the fly, using rubocop",
   "repository": "https://github.com/AtomLinter/linter-rubocop",
   "license": "MIT",
   "engines": {
-    "atom": ">=1.0.0 <2.0.0"
+    "atom": ">=1.4.0 <2.0.0"
+  },
+  "configSchema": {
+    "command": {
+      "type": "string",
+      "default": "rubocop",
+      "description": "This is the absolute path to your `rubocop` command. You may need to run `which rubocop` or `rbenv which rubocop` to find this. Examples: `/usr/local/bin/rubocop` or `/usr/local/bin/bundle exec rubocop --config /my/rubocop.yml`."
+    },
+    "disableWhenNoConfigFile": {
+      "type": "boolean",
+      "title": "Disable when no .rubocop.yml config file is found",
+      "default": false,
+      "description": "Only run linter if a RuboCop config file is found somewhere in the path for the current file."
+    }
   },
   "activationHooks": [
     "language-ruby:grammar-used",
     "language-ruby-on-rails:grammar-used",
     "language-chef:grammar-used"
   ],
   "scripts": {
-    "lint": "coffeelint lib && eslint .",
+    "lint": "eslint .",
     "test": "apm test"
   },
   "dependencies": {
     "atom-linter": "^9.0.0",
-    "escape-html": "^1.0.3"
+    "escape-html": "^1.0.3",
+    "pluralize": "^3.1.0"
   },
   "devDependencies": {
-    "coffeelint": "^1.15.0",
     "eslint": "^3.15.0",
     "eslint-config-airbnb-base": "^11.1.0",
-    "eslint-plugin-import": "^2.2.0"
+    "eslint-plugin-import": "^2.2.0",
+    "tmp": "^0.0.31"
   },
   "providedServices": {
     "linter": {
@@ -35,150 +49,23 @@
     }
   },
   "eslintConfig": {
-    "extends": "airbnb-base",
-    "globals": {
-      "atom": true
-    },
-    "env": {
-      "node": true
-    },
-    "rules": {
-      "global-require": "off"
-    }
-  },
-  "coffeelintConfig": {
-    "arrow_spacing": {
-      "level": "error"
-    },
-    "braces_spacing": {
-      "level": "error",
-      "spaces": 0,
-      "empty_object_spaces": 0
-    },
-    "camel_case_classes": {
-      "level": "error"
-    },
-    "coffeescript_error": {
-      "level": "error"
-    },
-    "colon_assignment_spacing": {
-      "level": "error",
-      "spacing": {
-        "left": 0,
-        "right": 1
-      }
-    },
-    "cyclomatic_complexity": {
-      "value": 10,
-      "level": "ignore"
-    },
-    "duplicate_key": {
-      "level": "error"
-    },
-    "empty_constructor_needs_parens": {
-      "level": "ignore"
-    },
-    "ensure_comprehensions": {
-      "level": "warn"
-    },
-    "eol_last": {
-      "level": "ignore"
-    },
-    "indentation": {
-      "value": 2,
-      "level": "error"
-    },
-    "line_endings": {
-      "level": "ignore",
-      "value": "unix"
-    },
-    "max_line_length": {
-      "value": 120,
-      "level": "warn",
-      "limitComments": true
-    },
-    "missing_fat_arrows": {
-      "level": "ignore",
-      "is_strict": false
-    },
-    "newlines_after_classes": {
-      "value": 3,
-      "level": "ignore"
-    },
-    "no_backticks": {
-      "level": "error"
-    },
-    "no_debugger": {
-      "level": "error",
-      "console": false
-    },
-    "no_empty_functions": {
-      "level": "ignore"
-    },
-    "no_empty_param_list": {
-      "level": "error"
-    },
-    "no_implicit_braces": {
-      "level": "ignore",
-      "strict": true
-    },
-    "no_implicit_parens": {
-      "strict": true,
-      "level": "ignore"
-    },
-    "no_interpolation_in_single_quotes": {
-      "level": "error"
-    },
-    "no_nested_string_interpolation": {
-      "level": "warn"
-    },
-    "no_plusplus": {
-      "level": "ignore"
-    },
-    "no_private_function_fat_arrows": {
-      "level": "warn"
-    },
-    "no_stand_alone_at": {
-      "level": "error"
-    },
-    "no_tabs": {
-      "level": "error"
-    },
-    "no_this": {
-      "level": "ignore"
-    },
-    "no_throwing_strings": {
-      "level": "error"
-    },
-    "no_trailing_semicolons": {
-      "level": "error"
-    },
-    "no_trailing_whitespace": {
-      "level": "error",
-      "allowed_in_comments": false,
-      "allowed_in_empty_lines": true
-    },
-    "no_unnecessary_double_quotes": {
-      "level": "error"
-    },
-    "no_unnecessary_fat_arrows": {
-      "level": "warn"
-    },
-    "non_empty_constructor_needs_parens": {
-      "level": "ignore"
-    },
-    "prefer_english_operator": {
-      "level": "error",
-      "doubleNotLevel": "ignore"
-    },
-    "space_operators": {
-      "level": "ignore"
-    },
-    "spacing_after_comma": {
-      "level": "error"
-    },
-    "transform_messes_up_line_numbers": {
-      "level": "warn"
-    }
-  }
+   "extends": "airbnb-base",
+   "rules": {
+     "global-require": "off",
+     "import/no-unresolved": [
+       "error",
+       {
+         "ignore": [
+           "atom"
+         ]
+       }
+     ]
+   },
+   "globals": {
+     "atom": true
+   },
+   "env": {
+     "node": true
+   }
+ }
 }

spec/linter-rubocop-spec.js

@@ -1,8 +1,12 @@
 'use babel';
 
 import * as path from 'path';
+import { truncateSync, writeFileSync, readFileSync } from 'fs';
 
-const lint = require('../lib/index.coffee').provideLinter().lint;
+// eslint-disable-next-line import/no-extraneous-dependencies
+import tmp from 'tmp';
+
+const lint = require('../src/index.js').provideLinter().lint;
 
 const badPath = path.join(__dirname, 'fixtures', 'bad.rb');
 const emptyPath = path.join(__dirname, 'fixtures', 'empty.rb');
@@ -131,4 +135,51 @@ describe('The RuboCop provider for Linter', () => {
       ),
     );
   });
+
+  describe('allows the user to autocorrect the current file', () => {
+    let doneCorrecting;
+    const tmpobj = tmp.fileSync({ postfix: '.rb' });
+    const checkNotificaton = (notification) => {
+      const message = notification.getMessage();
+      if (message === 'Linter-Rubocop: No fixes were made') {
+        expect(notification.getType()).toEqual('info');
+      } else {
+        expect(message).toMatch(/Linter-Rubocop: Fixed \d offenses/);
+        expect(notification.getType()).toEqual('success');
+      }
+      doneCorrecting = true;
+    };
+
+    beforeEach(() => {
+      truncateSync(tmpobj.name);
+      doneCorrecting = false;
+    });
+
+    it('corrects the bad file', () => {
+      writeFileSync(tmpobj.name, readFileSync(invalidWithUrlPath));
+      waitsForPromise(() =>
+        atom.workspace.open(tmpobj.name).then((editor) => {
+          atom.notifications.onDidAddNotification(checkNotificaton);
+          atom.commands.dispatch(atom.views.getView(editor), 'linter-rubocop:fix-file');
+        }),
+      );
+      waitsFor(
+        () => doneCorrecting,
+        'Notification type should be checked',
+      );
+    });
+
+    it("doesn't modify a good file", () => {
+      waitsForPromise(() =>
+        atom.workspace.open(goodPath).then((editor) => {
+          atom.notifications.onDidAddNotification(checkNotificaton);
+          atom.commands.dispatch(atom.views.getView(editor), 'linter-rubocop:fix-file');
+        }),
+      );
+      waitsFor(
+        () => doneCorrecting,
+        'Notification type should be checked',
+      );
+    });
+  });
 });