Dungeon Tweaks Compat again #228
Conversation
also with backwards compat
removed to match your current state
| */ | ||
| public static void registerDungeons() | ||
| { | ||
| if(isLegacy) return;//I supported this mod in older versions |
There was a problem hiding this comment.
yes I will download your formattor again I guess
| addDungeonMob.invoke(null,tower.getId(), nether ? new ResourceLocation("wither_skeleton") : new ResourceLocation("skeleton"), 120); | ||
| addDungeonMob.invoke(null,tower.getId(), new ResourceLocation("zombie"), 120); | ||
|
|
||
| if(nether) |
| import java.util.Random; | ||
|
|
||
| import com.evilnotch.dungeontweeks.main.world.worldgen.mobs.DungeonLocation; | ||
| import com.evilnotch.dungeontweeks.main.world.worldgen.mobs.DungeonMobs; |
There was a problem hiding this comment.
Pretty sure the idea of compat proxies is to avoid having to IMPORT the addons?
There was a problem hiding this comment.
ok I will remove the imports but, I don't use them. I converted them to reflection so you don't have to have my mod to compile even though it would be safe using it without the mod since loader is mod loaded
|
import statements do not exist in compiled code. I removed those import statements and the dungeon tweaks from the java build path in the last two commits. I forgot to remove it from the java build path and look for invalid imports my bad. If you are talking about DungeonTweaksCompat.class it's a class attatched directly to the battle towers commit The dungeon tweaks compat class is pure refelction currently. |
fixed exception cacheing spawner data when dungeon tweaks wasn't loaded optimized Loader.isModLoaded with cached boolean.
so this doesn't happen again
|
the mod works without dungeon tweaks and compiles without dungoen tweaks I don't see a problem with the pr sorry If I confused you. |
|
Is there still something wrong with this pull? I removed invalid imports reformated code you said was maul-formed and it's pure reflection thus it's a soft dependency. Sorry if your just to busy to take a look and merge. it's just that people want to play battle towers and dungeon tweaks without a crash this pull was to fix both old and new dungeon tweaks. |
|
Sorry, i was busy and reading scattered commits like this isn't easy. I looked over the squashed merge again and apart from a superfluous refactoring you did (adding Random as parameter when all you do is pull it from another parameter World beforehand...) it looks fine. I've updated the curse version with the new build. I hope you tested the result to be working runtime, because i did not. |
|
Yeah well I thought you were going to attempt to use random as vanilla minecraft does but, I was wrong. You use world.rand which in the same pos will have different stuffs every time on both structures and spawners according to the logic of your mod. So just ignore it. I was able to convert it to vanilla minecraft at least the spawners but, unless the structure itself is vanilla mc style I wouldn't fix it. vanilla mc logic is same seed same structure same loot same exact structure mobs etc.... |
|
Yes, i am not making sure it generates deterministic because i don't care, but if that is a point for you i can understand the reasoning. |
this has backwards compatibility with older dungeon tweaks and the core function re-write update of 1.2.5. This code is also cleaner I hope you will merge this. And yes still this is still a soft dependency
Why do you need to register dungeon entries by default now?: it's to instantiate weights that are not 0 for towers. Users are still able to override the weights via config file it's just the weight won't be default. Also my re-write didn't support any specific mob entries only definitions. If you need the method to be taken down I could add support on my side for weights but, the rest needs to happen.
Also if you don't like my nether specific enhancements by default when dungeon tweaks is loaded I could remove that and have users config them to be that or whatever they wanted. Just thought it would be cool.
Thanks for your time