[Ruins] templates can specify dimensions to spawn in #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll thumb AND merge it. BET YOU DIDNT SEE THAT ONE COMING |
|
Boom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to address Blackendsuns96571's post in the Minecraft Forum regarding compatibility with Galacticraft. It does have general utility, though, such as templates that, say, only spawn in the nether, or only in the overworld and Twilight Forest.
In addition, this change also supports biome names containing spaces, which Galacticraft uses (and possibly other mods).
Since this is a new feature, I'm not merging it myself, at least until I get a thumbs-up from AtomicStryker.