using cleanstop() causes non-zero exit, but does not show an error message (because it clears the screen)

[sourcejedi]

$ rpm -q atop
atop-2.3.0-10.fc28.x86_64

When atop hits a fatal error, it does not show an error message.

I happened to run atop after I had changed directory (cd) into a mounted USB stick. The "error" was that the USB connection was lost. Then atop died without printing any error (and returned exit status 53).

$ atop
$ echo $?
53

---

src/atop$ grep -r 'exit[ ]*[(]' .
...
various.c
577:		exit(13);
590:	exit(exitcode);
...
src/atop$ grep -r '53' .
...
photosyst.c
101:** Revision 1.16  2004/05/06 09:53:31  gerlof
107:** Revision 1.14  2003/07/08 13:53:21  gerlof
305:		cleanstop(53);
...

In the function photosyst():

	if ( getcwd(origdir, sizeof origdir) == NULL)
	{
		perror("save current dir");
		cleanstop(53);
	}

I see atop tries to print an error message. But then I expect cleanstop() restores the original screen. So it wipes out the error message :-).

[Atoptool]

New function mcleanstop (write error message after ncurses closed the window) solves this issue.

[sourcejedi]

Great! Thanks for the amazing program :-).