Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatop module needs updating for kernel >= 4.13.0 #8

Closed
ReubenM opened this issue Sep 12, 2017 · 3 comments
Closed

netatop module needs updating for kernel >= 4.13.0 #8

ReubenM opened this issue Sep 12, 2017 · 3 comments

Comments

@ReubenM
Copy link

ReubenM commented Sep 12, 2017

module build fails:

netatop-1.0/module/netatop.c: In function ‘init_module’:
netatop-1.0/module/netatop.c:1753:2: error: implicit declaration of function ‘nf_register_hook’ [-Werror=implicit-function-declaration]
  nf_register_hook(&hookin_ipv4);   // register hook
  ^~~~~~~~~~~~~~~~
netatop-1.0/module/netatop.c: In function ‘cleanup_module’:
netatop-1.0/module/netatop.c:1783:2: error: implicit declaration of function ‘nf_unregister_hook’ [-Werror=implicit-function-declaration]
  nf_unregister_hook(&hookin_ipv4);
  ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
@ReubenM
Copy link
Author

ReubenM commented Sep 30, 2017

The issue is that the two functions were dropped in 4.13.0-rc2 because they are not namespace aware. There are equivalent namespace aware functions, but just swapping them out is not enough. (Compiles and runs, but all network metrics are 0's). So there is some more changes needed to make it work that I don't have the expertise to go digging into.

@Atoptool
Copy link
Owner

Since netatop is not part of the atop repository, find the modified version 2.0 of netatop here:
https://www.atoptool.nl/downloadnetatop.php

Netatop will soon be a separate repository on GitHub.

zlandau added a commit to zlandau/atop that referenced this issue Feb 16, 2020
The load average reporting functions in showsys.c use static buffer
sizes. When the load averages on a machine are very large, this causes
the writes to extend past the buffer. With this commit, if a number is
too large then we just show '>NNNNNN'. I'm not sure if this is the best
choice, so I'm open to other ideas.

This is what the output looks like when we exceed the maximums:

  CPL | avg1 >999999 | avg5 >999999 | avg15 >99999 | csw 103117e3 | intr 88296e3 |

Note that this was triggered from a kernel that is reporting clearly
inaccurate numbers:

  $ cat /proc/loadavg
  1.25 2.40 368567045.47 1/589 53576

But regardless, crashing is no fun.

For future reference, I narrowed down the issue by building with
-fsanitize=address. For example:

  ==55396==ERROR: AddressSanitizer: global-buffer-overflow on address 0x55c527d6f14f at pc 0x7f4729942df9 bp 0x7ffe1fd30710 sp 0x7ffe1fd2fea0
  WRITE of size 10 at 0x55c527d6f14f thread T0
      #0 0x7f4729942df8 in __interceptor_vsprintf /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:1627
      Atoptool#1 0x7f47299432cf in __interceptor_sprintf /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:1670
      Atoptool#2 0x55c527d1c167 in sysprt_CPLAVG15 (/home/kapheine/projects/atop/atop+0x74167)
      Atoptool#3 0x55c527d2087a in showsysline (/home/kapheine/projects/atop/atop+0x7887a)
      Atoptool#4 0x55c527d1471f in prisyst (/home/kapheine/projects/atop/atop+0x6c71f)
      Atoptool#5 0x55c527d090ff in generic_samp (/home/kapheine/projects/atop/atop+0x610ff)
      Atoptool#6 0x55c527ce17c9 in main (/home/kapheine/projects/atop/atop+0x397c9)
      Atoptool#7 0x7f472952a022 in __libc_start_main (/usr/lib/libc.so.6+0x27022)
      Atoptool#8 0x55c527ce266d in _start (/home/kapheine/projects/atop/atop+0x3a66d)

  0x55c527d6f14f is located 49 bytes to the left of global variable 'buf' defined in 'showsys.c:981:54' (0x55c527d6f180) of size 15
  0x55c527d6f14f is located 0 bytes to the right of global variable 'buf' defined in 'showsys.c:1000:54' (0x55c527d6f140) of size 15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ReubenM @Atoptool and others