Typescript #27
Merged
Typescript #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better TS typings! * Few changes and fixes to be more robust * More deprecation notices, pls stop using common(fy) * Several other internal changes, end API should still work the same
Now it compiles and runs properly, yay!
Resolves #22
Signed-off-by: Jeroen Claassens <support@fanva.xyz>
- Revert to SMap<V> Generic - Use NPM in package scripts and CircleCI - Revert to "sites" as exported member, instead of SiteMap - Properly reference MIT license - Target NodeJS LTS (v10) at time of writing - Further revert to function keyword - Throw errors, not return them
Terser is more up2date than uglifyjs as described [in their description](https://www.npmjs.com/package/terser#why-choose-terser) Also it is future proofing, especially needed if we're going to target esnext. Also Also it will be default in webpack starting v5 so like.. community speaks right?
- Change to lib and target esnext - Include DS_Store in gitignore - Revert commonfy back to previous state - Make example runnable and remove semi's as requested - Remove requirement of casting to string[] for sites Signed-off-by: Jeroen Claassens <support@fanva.xyz>
Signed-off-by: Jeroen Claassens <support@fanva.xyz>
Various TypeScript related resolutions, fixes, additions, and electric boogaloo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type safety boys