Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prototype assign issue if Array.prototype was written to #39

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

AtoraSuunva
Copy link
Owner

See #38

booru crashed if you were to add a non-writeable property to Array.properties, like so:

Object.defineProperty(Array.prototype, 'random', {
  value: () => {},
  writable: false,
});

@AtoraSuunva AtoraSuunva merged commit 9ca9fa1 into master Dec 22, 2019
@AtoraSuunva AtoraSuunva deleted the fix/gh-38 branch February 5, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant