Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for saving unchecked boxes #906

Merged
merged 2 commits into from Jun 22, 2021
Merged

Conversation

mikaelmattsson
Copy link
Contributor

@mikaelmattsson mikaelmattsson commented May 2, 2021

Includes fixes by #862 but in a different way that uses the default argument of Request::get and make the markup the checkbox the same in the create and edit forms.

And also fix unchecking in edit event social.

Error message when saving social settings:

SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'social_show_whatsapp' cannot be null (SQL: update `events` set `social_show_linkedin` = 0, `social_show_email` = 0, `social_show_whatsapp` = ?, `events`.`updated_at` = 2021-05-02 10:39:54 where `id` = 2

@justynpride
Copy link
Contributor

@mikaelmattsson This is great. I hope it gets merged in soon.

@johannac
Copy link
Member

Thank you for submitting this @mikaelmattsson !

@robetus
Copy link

robetus commented Feb 8, 2022

How is this a fix? I'm still getting the error on 2.4.0 for the social checkboxes. What exactly is the fix please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants