Fix not using custom chatbox's colors #228
Conversation
Moved set_text_color_dropdown() to after current_char is actually updated with the selected char. Otherwise set_text_color_dropdown will try to update the colors with either nothing as character, or with the previously selected character. Use get_chat() so it actually gets the name of the custom chatbox instead of using the same name as the character. Remove the extra "c" since get_chat_color it's already called with this "c" in place.
|
Client crashes when trying to join DRO server for some reason, so I'll work more on this. |
For some reason the client would work just fine if set_text_color_dropdown() was called only once after updating the character selected by the user. But when joining a DRO server the client would crash just before loading the music.
instead of trying to find the character folder on misc
|
Why is this closed? Surely it fixes something. |
Also remove the comment explaining the crash if set_text_color_dropdown is removed from set_widgets
Because I found yet another bug related to this, so I wanted to work a little more on it before merging. |
|
Remember the draft button :^) |
Isn't that an option only when you create the PR? To be honest I thought this was ready when I first open it. But now I'm sure 👍 |
Originally you could only mark it as draft when creating the PR, but then they later added a button under the "reviewers" list to place it back into draft status. |
Nice, thanks |
| @@ -435,7 +435,7 @@ QString AOApplication::get_tagged_stylesheet(QString target_tag, QString p_file) | |||
|
|
|||
| QString AOApplication::get_chat_markdown(QString p_identifier, QString p_chat) | |||
| { | |||
| QString design_ini_path = get_base_path() + "misc/" + p_chat + "/config.ini"; | |||
| QString design_ini_path = get_base_path() + "misc/" + get_chat(p_chat) + "/config.ini"; | |||
There was a problem hiding this comment.
If the behavior changed in #230 is folded into get_chat per review, this might lead to unexpected behavior - in fact, one might begin to question what the purpose of the misc folder even is to begin with, if themes can take precedence over misc folders.
There was a problem hiding this comment.
Well, as far as this fix goes, get_chat_markdown was trying to access a folder named exactly as the character in misc. To me this is an obvious bug and should instead be reading the custom chatbox in misc. To me the order in which get_chat_markdown read ini files is something for another PR, #230 for example.
There was a problem hiding this comment.
I'll allow this bugfix to pass, but having to manage the precedence orders of individual asset types like this is not setting a good precedent and will take various passes of what they call "un-fucking" later on.
There was a problem hiding this comment.
I agree, and like I said I can't wait to help you in what I can extinguishing the AO dumpster fire with the 2.9 branch.
…on-ooc-message-reception Fix general client stutter when OOC messages are rendered
Fix #194