-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple cache #106
Closed
Closed
Simple cache #106
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
be1943a
Added lru_cache with configurable maxsize to the API call interface
sjvrijn ea044ee
caching switch added
sjvrijn 7a2633b
initializing cache using Config.factory() rather than default values
sjvrijn 53fb655
clearing cache upon 'put' call
sjvrijn 5642afa
Clearing cache on any 'put', 'post' or 'delete' API call
sjvrijn File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I am afraid we can't do this.
Config.factory()
will always give you the default~/.togglrc
configuration, which might not be desired for people who build their ownConfig
instance that they pass to the API Wrappers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm we could wrap instead of
toggl()
the_toggl_request()
function and then intoggl()
decide based on the passedconfig
if used the cached version or instead non-cached version using the ability to bypass the cache using_toggl_request. __wrapped__()
attribute thatlru_cache
expose. This then can be also used to ignore cache for POST/DELETE/PUT requests.But still, it leaves us with the problem of caching error response...