-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cross Platform Support for toggl-cli Path #295
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Move DEFAULT_CONFIG_PATH to toggl/utils/config.py Use absolute import in commands.py Closes #126
Thanks for the PR! It has been long standing issue :-) I have a question though, how does this fits into multi-OS environment? I am not sure if |
44a18cd
to
c0cd4db
Compare
You are correct! It seems I failed to notice cross platform compatibility while looking through this. In such cases, If backward compatibility is required, then Does toggl-cli still supports any python version before 3.5? |
We are supporting only currently supported Python versions, so that means The only thing I would ask you is, can you please either rebase or recreate the PR? I have been doing some bad stuff (eq. force pushing master 🙈 😅 ) in order to get the new CI release mechanism working... Which finally does, but it bit corrupted your PR unfortunately, sorry about that. |
Sure, no worries 👍 |
I don't think DEFAULT_CONFIG_PATH in commands.py is doing anything. It can be a oversight. Can you take a look over it? |
You are right :-) It is the one in |
Move DEFAULT_CONFIG_PATH to toggl/utils/config.py
Use absolute import in commands.py
Closes #126