fix: projects and tasks #305
Conversation
Fixes api.Task.objects.all() since that response data is still wrapped in an envelope.
|
Thanks for the PR. Do you target the new v9 of API? If so then this project still uses the old v8 version as you can see here: https://github.com/AuHau/toggl-cli/blob/master/toggl/toggl.py#L5 so I am not sure if your changes applies here? |
|
@AuHau yeah, I thinked you missed that the PR is targeting your new-api-version branch. |
| if isinstance(fetched_entities, dict): | ||
| fetched_entities = fetched_entities.get('data') |
There was a problem hiding this comment.
Hmm I am wondering if it wouldn't make more sense to have this in utils.toggl? I guess the main fetching (eq. GET requests) are coming from the TogglSet but maybe it would be applicable also for other responses? WDYT?
There was a problem hiding this comment.
I really have no strong opinion here since I only made these changes to get a broken tool using this project up and running again and have very little context.
But if I read this correct, https://github.com/AuHau/toggl-cli/blob/feat/new-api-version/toggl/utils/others.py#L149 , it should return an dict right?
And I think the problem was that for calls without the envelop, it return a list.
I do think it would be easier to discuss that on the other PR once all changes needed for V9 are identified.
|
Oh you are right! Ups, sorry about that! 🙈 |
AuHau
changed the title
Fixes api.Project.objects.all() since color is now a string.
Fixes api.Task.objects.all() since that response data is still wrapped in an envelope.