New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wren + arm64 => wrong float properties #669
Comments
|
Now the question is: is this still crashing for Cubase 12.0.30 + macOS |
Reproduced in Cubase Pro 12, before fix, crashes at instantiation while displaying a non-Wren-styled UI (or perhaps, partially styled)
|
Log from Cubase
|
Mmmmm, bug is
|
Repro script:
|
Perhaps, quite simply, we never tested Wren on arm64
|
A matrix for testing if the center knob of Distort is properly drawn:
So yeah apart from the Logic mystery the Distort bug seems related to arm64 and |
Distort's problem: knobRadiusPx is small. because knobRadius is set to zero |
Wren instructions trace
The Wren properties:
The styling code:
so... why would the local hold zero instead of 0.65? |
The wren line: ($"_driveKnob").knobRadius(0.65) // does nothing yet, but an UIKnob is returned
.numLEDs(15)
.LEDRadiusMin(0.06)
.LEDRadiusMax(0.06) compiles to instructions:
which is wrong since the literals just get truncated after the dot... |
In Rosetta, correctly compiled to:
|
Numbers are parsed with strtod and strtod is locale dependent, would it be possible that in arm64 C runtime uses a different locale? |
|
FLStudio and Cubase on arm64 set the C locale to french???
and Wren uses which means many other arm64 things will break. Shame. |
|
Need scanf and strtod replacement for parsing float without locale interaction => #711 |
Should be okay now if you use Dplug v12.7.22+ and wrep-port v1.1.4+, just need to test that. |
Fixed. |
Also reported by QA: Cubase 12.0.30 + macOS => crash
The text was updated successfully, but these errors were encountered: