Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramping Apple Effects parameters doesn't change the parameter at all #2588

Closed
eljeff opened this issue Sep 1, 2021 · 2 comments
Closed

Ramping Apple Effects parameters doesn't change the parameter at all #2588

eljeff opened this issue Sep 1, 2021 · 2 comments
Labels

Comments

@eljeff
Copy link
Member

eljeff commented Sep 1, 2021

Here is code to show that using LowPassFilter.$cutoffFrequency.ramp(to: value, duration: someTime) has no effect on the actual filter.cutoffFrequency

I put this code in GenericNodeTests.swift

func testLowpass() {
    let engine = AudioEngine()
    let url = Bundle.module.url(forResource: "12345", withExtension: "wav", subdirectory: "TestResources")!
    let input = AudioPlayer(url: url)!
    let effect = LowPassFilter(input)
    engine.output = effect
    let startFreq: Float = 100
    let targetFreq: Float = 1000
    let rampDuration: Float = 0.1
    effect.cutoffFrequency = startFreq
    effect.$cutoffFrequency.ramp(to: targetFreq, duration: rampDuration)
    let audio = engine.startTest(totalDuration: 1.0)
    input.start()
    audio.append(engine.render(duration: 1.0))
    testMD5(audio)
    XCTAssertEqual(effect.cutoffFrequency, targetFreq)
}
@aure
Copy link
Member

aure commented Sep 2, 2021

This seems to be true for all the Apple effects. Delay, Distortion, etc. all of the ones that come with the regular AudioKit swift package.

@aure aure changed the title LowpassFilter.ramp doesnt work Ramping Apple Effects parameters doesn't change the parameter at all Sep 2, 2021
@aure aure added the wontfix label Sep 2, 2021
@aure
Copy link
Member

aure commented Sep 2, 2021

Add a warning when trying to ramp a parameter that is intrinsically not rampable. Apple should be made aware of this limitation so I've added this as one of the radars we should file with them: #2570

@aure aure closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants