Implement RenderMeasurer #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenderMeasurer measures CPU load of given audio unit. It can be used for user facing CPU meter, but also for automated performance testing.
jcavar
commented
Mar 15, 2024
| } | ||
|
|
||
| _Nonnull AURenderObserver createObserver() { | ||
| auto sharedThis = std::shared_ptr<RenderMeasurer>(this); |
There was a problem hiding this comment.
I believe this pattern is realtime safe, but I would like someone more experienced with C++ to comment on it.
aure
approved these changes
Mar 15, 2024
|
I think you'd have to bump up the Swift Version number to get this PR to pass tests. Do you want to try that or shall I just accept the PR? |
jcavar
force-pushed
the
feature/render-measure
branch
from
806414b
to
aca2dfe
Compare
|
@aure I've updated Swift version to 5.9. iOS tests are now passing, but macOS and tvOS are failing. It seems like failures are in other areas that I haven't touched, were these passing before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderMeasurer measures CPU load of given audio unit. It can be used for user facing CPU meter, but also for automated performance testing.