Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Xcode 15 and Swift 5.9 compiler #14

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

jwyterlin
Copy link

This PR fixes an issue that prevents to build it for Xcode 15.
Because of the new Swift compiler (5.9) it's needed to include cassert header.

Here is the error compiler outputs:

Screenshot 2023-06-07 at 14 27 04 Screenshot 2023-06-07 at 14 26 41

In the build report too:

Screenshot 2023-06-07 at 14 29 21 Screenshot 2023-06-07 at 14 28 21

Copy link
Member

@aure aure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried about the changed md5s. Have you listened to the output to make sure that the sounds have not changed? I have a feeling this change will not pass the CI tests.

@NickCulbertson
Copy link
Member

@jwyterlin Do the test changes need to be in this PR? The cassert header part should probably be added, but the test changes would need further review/explanation.

@jwyterlin
Copy link
Author

jwyterlin commented Jun 28, 2023

@jwyterlin Do the test changes need to be in this PR? The cassert header part should probably be added, but the test changes would need further review/explanation.

No, they are not needed for the cassert header part.

But when I ran the unit tests, they did not pass.
That was the reason I changed the tests.
As I can see here now, the CI is raising other errors beyond the Test Matrix.
All the failures tell us that compiler is not finding the method loadUnaligned(fromByteOffset:as:)
for UnsafeRawPointer

Compilers: Swift 5.5 and 5.6
Equivalent Xcode versions:
Xcode 13.3, Swift 5.6, Released at March 14th 2022
Xcode 13.0, Swift 5.0, Released at September 20th 2021

but this method is available since iOS 8.0 ( Link here )

Would it be possible to update the Xcode version?
Or do you guys prefere to support these old versions too?

aure added a commit that referenced this pull request Jul 11, 2023
@aure aure closed this Jul 11, 2023
@aure aure reopened this Jul 11, 2023
@aure aure merged commit fe8ac01 into AudioKit:main Jul 11, 2023
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants