Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading of SFZ improved: loop_mode=no_loop, fixes #21 #22

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

mahal
Copy link
Contributor

@mahal mahal commented Jan 11, 2024

Improved reading of SFZ files:

  • loop_mode=no_loop will no longer loop the sample

https://sfzformat.com/opcodes/loop_mode/

@NickCulbertson
Copy link
Member

NickCulbertson commented Jan 11, 2024

Wouldn't this flip the default isLooping bool for existing users that haven't set its value, like here.

Would it be possible to use something like isLooping: loopMode != "no_loop" || loopMode != "", or change the line where it is declared to be var loopMode = "no_loop"?

@mahal
Copy link
Contributor Author

mahal commented Jan 12, 2024

@NickCulbertson Thanks for reviewing. I had the feeling that I'm missing something but couldn't quite point it out; now I know. I have added the line where it is declared as this anyway is the default stated in the sfzformat.com documentation.

@NickCulbertson
Copy link
Member

This looks good to me!

cc: @aure

@NickCulbertson NickCulbertson merged commit 453580d into AudioKit:main Jan 16, 2024
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants